jagjeet
2020-12-23 01:41:31
you should unsubscribe
there is no problem regarding memory leak as http observables are completed after first response.
but your logic in subscribe block can cause problem, for example if your api call is taking too long and user decides to leave the page then in that case since you have not unsubscribed the observable your logic such as login or navigation inside subscribe can cause problems
and just to inform you this question has been already answered here
Is it necessary to unsubscribe from observables created by Http methods?
you can refer to this link for detailed answers
热门帖子
热门github
6
Thanks for answering the question. I did see that link but wondered if because I had my get request in one file and then the subscribe in another file, it made any difference whatsoever in regards to unsubscribing etc. It seems its better to unsubscribe either way so I'll continue to do that - thanks again.
it is the same thing eventually you are making an http request and subscribing to it