My OWIN middleware is like this. (Framework is ASP.NET Web API).
public class MyMiddleware : OwinMiddleware
{
public MyMiddleware(OwinMiddleware next) : base(next) { }
public override async Task Invoke(OwinRequest request, OwinResponse response)
{
var header = request.GetHeader("X-Whatever-Header");
await Next.Invoke(request, response);
response.SetHeader("X-MyResponse-Header", "Some Value");
response.StatusCode = 403;
}
}
Questions:
Is it the recommended practice to derive from OwinMiddleware
? I see that in Katana source, some of the middleware classes derive from OwinMiddleware
and some do not.
I can see the request headers okay. Setting response header or status code after Next.Invoke
in my middleware has no effect on the response returned to the client. But if I set the response header or status before the Next.Invoke
call, the response with headers and the status that I set is returned to the client. What is the right way of setting these?
Yes, deriving from OwinMiddleware is recommended. The reason some middleware classes don't derive from OwinMiddleware is that either they haven't switched over yet because the class was introduced recently. Or to avoid having the assembly take a dependency on the Microsoft.Owin assembly for some reason.
The probable reason setting stuff on the response after calling Invoke on Next doesn't work is that the response HTTP header gets sent as soon as anyone starts writing to the response body stream. So any changes to status code or HTTP headers after a middleware component starts writing to the response body won't have any effect.
What you can try doing is to use the OnSendingHeaders callback that OWIN provides. Here's how you can use it:
public override async Task Invoke(IOwinContext context)
{
var response = context.Response;
var request = context.Request;
response.OnSendingHeaders(state =>
{
var resp = (OwinResponse)state;
resp.Headers.Add("X-MyResponse-Header", "Some Value");
resp.StatusCode = 403;
resp.ReasonPhrase = "Forbidden";
}, response);
var header = request.Headers["X-Whatever-Header"];
await Next.Invoke(context);
}
Credit to biscuit314 for updating my answer.
Thanks Youssef. For point #2, is there an example code in Katana source or somewhere else that I can look at, from the best practice pt of view? I believe, what I'm asking for is a fairly common need and is every one supposed to do this stream switching just to set a response header, if we use OWIN middleware? Any pointers will be appreciated.
I'm able to resolve the problem by following your suggestion but isn't there an easy way out? I mean this is too much of work to just set a response header on the way out, especially if one is used to Web API's message handler.
Updated the answer with a simpler method. Please let me know if it works.
"Yes, deriving from OwinMiddleware is recommended." No, no it is not. github.com/owin/owin/issues/20 github.com/owin/owin/issues/19
@Valipour, the OnSendingHeaders callback only runs once data starts being sent on the wire, so you should be able to inspect the response at that point